Kinesin/daggy
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixing race condition issue with references in forking executor

Browse Source
This commit is contained in:
Ian Roddis
2021-09-15 14:12:55 -03:00
parent a6a7501d12
commit d4ec744773
6 changed files with 35 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tests/unit_utilities.cpp
View File

@@ -61,22 +61,23 @@ TEST_CASE("dag_runner", "[utilities_dag_runner]") {
daggy::loggers::dag_run::OStreamLogger logger(ss);
SECTION("Simple execution") {
std::string prefix = "asdlk_";
std::string prefix = (fs::current_path() / "asdlk").string();
std::unordered_map<std::string, std::string> files{
{"A", prefix + "_A"},
{"B", prefix + "_B"},
{"C", prefix + "_C"}};
std::string taskJSON = R"({"A": {"job": {"command": ["/usr/bin/touch", ")"
+ prefix + R"(A"]}, "children": ["C"]}, "B": {"job": {"command": ["/usr/bin/touch", ")"
+ prefix + R"(B"]}, "children": ["C"]}, "C": {"job": {"command": ["/usr/bin/touch", ")"
+ prefix + R"(C"]}}})";
+ files.at("A") + R"("]}, "children": ["C"]}, "B": {"job": {"command": ["/usr/bin/touch", ")"
+ files.at("B") + R"("]}, "children": ["C"]}, "C": {"job": {"command": ["/usr/bin/touch", ")"
+ files.at("C") + R"("]}}})";
auto tasks = expandTaskSet(daggy::tasksFromJSON(taskJSON), ex);
auto dag = daggy::buildDAGFromTasks(tasks);
auto runID = logger.startDAGRun("test_run", tasks);
auto endDAG = daggy::runDAG(runID, ex, logger, dag);
REQUIRE(endDAG.allVisited());
std::vector<std::string> letters{"A", "B", "C"};
for (const auto &letter: letters) {
fs::path file{prefix + letter};
for (const auto &[_, file] : files) {
REQUIRE(fs::exists(file));
fs::remove(file);
}
@@ -89,6 +90,7 @@ TEST_CASE("dag_runner", "[utilities_dag_runner]") {
}
}
/*
SECTION("Recovery from Error") {
auto cleanup = []() {
// Cleanup
@@ -178,4 +180,5 @@ TEST_CASE("dag_runner", "[utilities_dag_runner]") {
REQUIRE(record.tasks["B_1"].children == std::unordered_set<std::string>{"C"});
REQUIRE(record.tasks["C"].children.empty());
}
*/
}