Implement a bunch of clang-tidy suggested changes. Remove FilesystemLogger

tests/unit_dag.cpp

@@ -53,14 +53,14 @@ TEST_CASE("dag_traversal", "[dag]")
   std::vector<std::pair<int, int>> edges{{0, 6}, {1, 5}, {5, 6}, {6, 7}, {2, 3},
                                          {3, 5}, {4, 7}, {7, 8}, {7, 9}};
 
-  for (auto const [from, to] : edges) {
+  for (const auto &[from, to] : edges) {
     dag.addEdge(from, to);
   }
 
   SECTION("Basic Traversal")
   {
     dag.reset();
-    std::vector<int> visitOrder(N_VERTICES);
+    std::vector<size_t> visitOrder(N_VERTICES);
     size_t i = 0;
     while (!dag.allVisited()) {
       const auto v = dag.visitNext().value();
@@ -70,7 +70,7 @@ TEST_CASE("dag_traversal", "[dag]")
     }
 
     // Ensure visit order is preserved
-    for (auto const [from, to] : edges) {
+    for (const auto &[from, to] : edges) {
       REQUIRE(visitOrder[from] <= visitOrder[to]);
     }
   }