Implement a bunch of clang-tidy suggested changes. Remove FilesystemLogger

tests/unit_server.cpp

@@ -7,12 +7,12 @@
 #include <daggy/executors/task/ForkingTaskExecutor.hpp>
 #include <daggy/loggers/dag_run/OStreamLogger.hpp>
 #include <filesystem>
-#include <fstream>
 #include <iostream>
 
 namespace rj = rapidjson;
 
-Pistache::Http::Response REQUEST(std::string url, std::string payload = "")
+Pistache::Http::Response REQUEST(const std::string &url,
+                                 const std::string &payload = "")
 {
   Pistache::Http::Experimental::Client client;
   client.init();
@@ -28,12 +28,12 @@ Pistache::Http::Response REQUEST(std::string url, std::string payload = "")
   request.then(
       [&](Pistache::Http::Response rsp) {
         ok       = true;
-        response = rsp;
+        response = std::move(rsp);
       },
       [&](std::exception_ptr ptr) {
         error = true;
         try {
-          std::rethrow_exception(ptr);
+          std::rethrow_exception(std::move(ptr));
         }
         catch (std::exception &e) {
           msg = e.what();