Kinesin/daggy
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Adding check for non-existent dagid

Browse Source
This commit is contained in:
Ian Roddis
2021-09-16 11:03:47 -03:00
parent e895103b1c
commit fac741742a
2 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
daggy/src/loggers/dag_run/OStreamLogger.cpp
View File

@@ -111,6 +111,9 @@ namespace daggy {
} }
DAGRunRecord OStreamLogger::getDAGRun(DAGRunID dagRunID) { DAGRunRecord OStreamLogger::getDAGRun(DAGRunID dagRunID) {
if (dagRunID >= dagRuns_.size()) {
throw std::runtime_error("No such DAGRun ID");
}
std::lock_guard<std::mutex> lock(guard_); std::lock_guard<std::mutex> lock(guard_);
return dagRuns_[dagRunID]; return dagRuns_[dagRunID];
} }

5
tests/unit_server.cpp
View File

@@ -71,6 +71,11 @@ TEST_CASE("rest_endpoint", "[server_basic]") {
REQUIRE(response.code() == Pistache::Http::Code::Ok); REQUIRE(response.code() == Pistache::Http::Code::Ok);
} }
SECTION ("Querying a non-existent dagrunid should fail ") {
auto response = REQUEST(baseURL + "/v1/dagrun/100");
REQUIRE(response.code() != Pistache::Http::Code::Ok);
}
SECTION("Simple DAGRun Submission") { SECTION("Simple DAGRun Submission") {
std::string dagRun = R"({ std::string dagRun = R"({
"name": "unit_server", "name": "unit_server",