Fixing serialization for manufacturers in schema

alembic/versions/a192abbf4091_add_manufacturers_table.py

@@ -28,12 +28,19 @@ def upgrade() -> None:
         sa.Column("logo_url", sa.String(), nullable=True),
         sa.PrimaryKeyConstraint("id"),
     )
+    # batch_alter_table's alter_column doesn't emit CREATE TYPE for the new
+    # Enum on its own (unlike create_table, which ties enum creation to the
+    # table-create DDL event) - create it explicitly first, or Postgres fails
+    # with `type "uncseries" does not exist`. checkfirst / no-op on SQLite.
+    uncseries = sa.Enum("UNC", "UNF", "UNEF", "UN", "UNS", name="uncseries")
+    uncseries.create(op.get_bind(), checkfirst=True)
     with op.batch_alter_table("unc_threads", schema=None) as batch_op:
         batch_op.alter_column(
             "series",
             existing_type=sa.VARCHAR(length=8),
-            type_=sa.Enum("UNC", "UNF", "UNEF", "UN", "UNS", name="uncseries"),
+            type_=uncseries,
             existing_nullable=False,
+            postgresql_using="series::uncseries",
         )
 
     # ### end Alembic commands ###
@@ -47,7 +54,9 @@ def downgrade() -> None:
             existing_type=sa.Enum("UNC", "UNF", "UNEF", "UN", "UNS", name="uncseries"),
             type_=sa.VARCHAR(length=8),
             existing_nullable=False,
+            postgresql_using="series::varchar(8)",
         )
+    sa.Enum(name="uncseries").drop(op.get_bind(), checkfirst=True)
 
     op.drop_table("manufacturers")
     # ### end Alembic commands ###

app/models/manufacturer.py

@@ -8,5 +8,5 @@ class Manufacturer(Base):
 
     id: Mapped[int] = mapped_column(primary_key=True)
     name: Mapped[str] = mapped_column(nullable=False)
-    url: Mapped[str] = mapped_column(nullable=False)
+    url: Mapped[str] = mapped_column(nullable=True)
     logo_url: Mapped[str | None] = mapped_column(nullable=True, default=None)

app/schemas/manufacturer.py

@@ -3,7 +3,7 @@ from pydantic import BaseModel, ConfigDict, HttpUrl
 
 class ManufacturerBase(BaseModel):
     name: str
-    url: HttpUrl
+    url: HttpUrl | None = None
     logo_url: HttpUrl | None = None